[fix](tvf) Support fs.defaultFS with postfix '/' #33202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38926 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 181250 ms |
ClickBench: Total hot run time: 29.76 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39239 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 179766 ms |
ClickBench: Total hot run time: 30.44 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
PR approved by anyone and no changes requested. |
AshinGau
approved these changes
Apr 3, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 3, 2024
morningman
added a commit
that referenced
this pull request
Apr 3, 2024
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 7, 2024
For HDFS tvf like: ``` select count(*) from hdfs( "uri" = "hdfs://HDFS8000871/path/to/1.parquet", "fs.defaultFS" = "hdfs://HDFS8000871/", "format" = "parquet" ); ``` Before, if the `fs.defaultFS` is end with `/`, the query will fail with error like: ``` reason: RemoteException: File does not exist: /user/doris/path/to/1.parquet ``` You can see that is a wrong path with wrong prefix `/user/doris` User need to set `fs.defaultFS` to `hdfs://HDFS8000871` to avoid this error. This PR fix this issue
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
For HDFS tvf like:
Before, if the
fs.defaultFSis end with/, the query will fail with error like:You can see that is a wrong path with wrong prefix
/user/dorisUser need to set
fs.defaultFStohdfs://HDFS8000871to avoid this error.This PR fix this issue
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...