Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](merge-iterator) fix NOT_IMPLEMENTED_ERROR when read next block view #32961 #33146

Merged

Conversation

liaoxin01
Copy link
Contributor

cherry pick from #32961

@liaoxin01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 49580 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e9c707588b6d4e38be823e9f9efa5d104cde1733, data reload: false

------ Round 1 ----------------------------------
q1	17615	4388	4311	4311
q2	2052	154	137	137
q3	10500	1933	1904	1904
q4	10379	1261	1324	1261
q5	8447	3919	3975	3919
q6	227	122	121	121
q7	2024	1608	1602	1602
q8	9308	2706	2707	2706
q9	10568	10667	10378	10378
q10	8607	3493	3522	3493
q11	425	241	237	237
q12	455	289	291	289
q13	18358	3960	4054	3960
q14	355	318	316	316
q15	513	448	453	448
q16	704	590	589	589
q17	1127	955	960	955
q18	7259	6748	6956	6748
q19	1668	1497	1490	1490
q20	517	296	305	296
q21	4484	4022	4068	4022
q22	494	407	398	398
Total cold run time: 116086 ms
Total hot run time: 49580 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4338	4291	4292	4291
q2	320	215	214	214
q3	4135	4160	4115	4115
q4	2728	2737	2736	2736
q5	7220	7156	7182	7156
q6	231	113	115	113
q7	3248	2877	2867	2867
q8	4329	4464	4486	4464
q9	17111	17086	16954	16954
q10	4267	4234	4262	4234
q11	744	674	702	674
q12	1011	861	864	861
q13	6982	3744	3733	3733
q14	447	431	416	416
q15	505	463	452	452
q16	767	701	695	695
q17	3821	3804	3853	3804
q18	8805	8645	8663	8645
q19	1706	1694	1655	1655
q20	2388	2147	2118	2118
q21	8474	8379	8434	8379
q22	1071	963	954	954
Total cold run time: 84648 ms
Total hot run time: 79530 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.79% (8046/21294)
Line Coverage: 29.46% (65723/223064)
Region Coverage: 28.93% (33819/116916)
Branch Coverage: 24.78% (17360/70070)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e9c707588b6d4e38be823e9f9efa5d104cde1733_e9c707588b6d4e38be823e9f9efa5d104cde1733/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 202206 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e9c707588b6d4e38be823e9f9efa5d104cde1733, data reload: false

query1	924	386	384	384
query2	6521	2348	2048	2048
query3	6917	195	194	194
query4	20018	17874	17901	17874
query5	19728	6544	6521	6521
query6	289	206	220	206
query7	4145	301	294	294
query8	253	240	252	240
query9	3172	2782	2672	2672
query10	405	269	296	269
query11	11267	10918	10788	10788
query12	121	73	73	73
query13	5583	646	642	642
query14	18661	13563	13685	13563
query15	357	238	230	230
query16	6554	275	256	256
query17	2916	2407	872	872
query18	2507	418	409	409
query19	195	149	143	143
query20	79	74	78	74
query21	185	96	94	94
query22	5208	5159	5250	5159
query23	33222	32891	32165	32165
query24	7522	6551	6531	6531
query25	531	424	422	422
query26	533	156	156	156
query27	1871	294	295	294
query28	6111	2277	2242	2242
query29	2908	2719	2806	2719
query30	238	160	162	160
query31	900	714	722	714
query32	68	59	47	47
query33	393	240	249	240
query34	825	458	483	458
query35	1125	885	899	885
query36	1253	1175	1213	1175
query37	88	63	58	58
query38	3023	2958	2897	2897
query39	1378	1310	1318	1310
query40	207	97	95	95
query41	35	32	32	32
query42	80	81	81	81
query43	607	605	630	605
query44	1132	718	734	718
query45	239	228	227	227
query46	1232	991	968	968
query47	1920	1799	1791	1791
query48	985	668	658	658
query49	619	355	359	355
query50	875	632	598	598
query51	4741	4676	4629	4629
query52	85	87	70	70
query53	439	322	312	312
query54	2648	2467	2476	2467
query55	82	86	83	83
query56	205	205	203	203
query57	1182	1128	1049	1049
query58	218	189	182	182
query59	3695	3417	3404	3404
query60	199	210	197	197
query61	83	83	86	83
query62	875	513	522	513
query63	462	331	333	331
query64	2537	1494	1467	1467
query65	3661	3546	3543	3543
query66	757	374	366	366
query67	16326	17581	15314	15314
query68	6892	634	661	634
query69	557	330	343	330
query70	1589	1490	1298	1298
query71	400	307	315	307
query72	6598	3488	3444	3444
query73	722	319	328	319
query74	6260	5864	5831	5831
query75	4641	3740	3655	3655
query76	4421	1168	1206	1168
query77	536	261	253	253
query78	12551	11716	11454	11454
query79	9960	631	664	631
query80	3103	400	378	378
query81	508	234	227	227
query82	1647	100	95	95
query83	171	137	125	125
query84	256	68	67	67
query85	1347	275	278	275
query86	346	291	296	291
query87	3197	3034	2995	2995
query88	5217	2303	2303	2303
query89	481	288	289	288
query90	1779	214	197	197
query91	149	116	111	111
query92	58	52	52	52
query93	6585	613	618	613
query94	890	200	197	197
query95	1103	1074	1065	1065
query96	632	338	320	320
query97	6653	6603	6423	6423
query98	180	182	170	170
query99	3092	899	871	871
Total cold run time: 316641 ms
Total hot run time: 202206 ms

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

ClickBench: Total hot run time: 30.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e9c707588b6d4e38be823e9f9efa5d104cde1733, data reload: false

query1	0.02	0.02	0.02
query2	0.06	0.02	0.02
query3	0.24	0.04	0.05
query4	1.81	0.08	0.07
query5	0.52	0.53	0.52
query6	1.24	0.66	0.62
query7	0.01	0.01	0.01
query8	0.04	0.02	0.02
query9	0.52	0.47	0.49
query10	0.53	0.52	0.53
query11	0.12	0.09	0.09
query12	0.12	0.09	0.09
query13	0.62	0.63	0.60
query14	0.77	0.79	0.80
query15	0.78	0.76	0.76
query16	0.35	0.36	0.37
query17	1.02	1.02	1.00
query18	0.23	0.26	0.24
query19	1.91	1.83	1.86
query20	0.02	0.01	0.01
query21	15.47	0.57	0.58
query22	1.99	1.91	1.32
query23	17.08	0.96	1.17
query24	8.70	0.96	0.85
query25	0.41	0.11	0.05
query26	0.79	0.16	0.14
query27	0.05	0.03	0.04
query28	4.79	0.79	0.73
query29	12.65	2.38	2.32
query30	0.60	0.51	0.50
query31	2.83	0.38	0.37
query32	3.38	0.50	0.49
query33	3.10	3.10	3.09
query34	15.26	4.80	4.78
query35	4.84	4.87	4.83
query36	1.04	1.03	1.00
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.07	0.01	0.02
query42	0.02	0.02	0.02
query43	0.02	0.01	0.02
Total cold run time: 104.29 s
Total hot run time: 30.36 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e9c707588b6d4e38be823e9f9efa5d104cde1733 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       20.5 seconds inserted 10000000 Rows, about 487K ops/s

@dataroaring dataroaring merged commit f52183d into apache:branch-2.0 Apr 2, 2024
26 of 29 checks passed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants