Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[profile](name) add table rollup name in profile #33137

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[profile](name) add table rollup name in profile #33137

merged 2 commits into from
Apr 2, 2024

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

add select rollup name in profile, eg:

  VNewOlapScanNode(baseall(test_rollup_name))  (id=0):(Active:  179.574us,  %  non-child:  0.00%)
        -  RuntimeFilters:  :  
        -  PushDownPredicates:  []

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhangstar333
Copy link
Contributor Author

run buildall

@zhangstar333
Copy link
Contributor Author

run buildall

HappenLee
HappenLee approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xinyiZzz
xinyiZzz approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 108f4fd into apache:master Apr 2, 2024
30 of 32 checks passed
yiguolei pushed a commit that referenced this pull request Apr 2, 2024
@zhangstar333 @Doris-Extras
[profile](name) add table rollup name in profile (#33137)
4d18fc1
@yiguolei yiguolei mentioned this pull request Apr 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinyiZzz xinyiZzz xinyiZzz approved these changes

@HappenLee HappenLee HappenLee approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangstar333 @yiguolei @HappenLee @xinyiZzz