Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix](Iceberg Catalog) Fix iceberg catalog of hms and hadoop not support iceberg properties #33113

Conversation

GoGoWen
Copy link
Contributor

@GoGoWen GoGoWen commented Apr 1, 2024

Proposed changes

when use use iceberg catalog with hms or hadoop type, we can not set the iceberg properties like "io.manifest.cache-enabled" to enable manifest cache in iceberg.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@GoGoWen
Copy link
Contributor Author

GoGoWen commented Apr 2, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit b417ef3 into apache:master Apr 5, 2024
28 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Apr 7, 2024
…upport iceberg properties (#33113)

* fix iceberg catalog of  hms and hadoop not support iceberg properties

* remove unused import
@yiguolei yiguolei mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.x dev/2.1.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants