Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](merge-iterator) fix NOT_IMPLEMENTED_ERROR when read next block view #32961

Merged
merged 1 commit into from
Mar 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions be/src/vec/olap/vgeneric_iterators.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -422,9 +422,9 @@ Status VUnionIterator::current_block_row_locations(std::vector<RowLocation>* loc
RowwiseIteratorUPtr new_merge_iterator(std::vector<RowwiseIteratorUPtr>&& inputs,
int sequence_id_idx, bool is_unique, bool is_reverse,
uint64_t* merged_rows) {
if (inputs.size() == 1) {
return std::move(inputs[0]);
}
// when the size of inputs is 1, we also need to use VMergeIterator, because the
// next_block_view function only be implemented in VMergeIterator. The reason why
// the size of inputs is 1 is that the segment was filtered out by zone map or others.
return std::make_unique<VMergeIterator>(std::move(inputs), sequence_id_idx, is_unique,
is_reverse, merged_rows);
}
Expand Down
Loading