Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](hive-writer) Fix the issue of block was not copied to do filtering when hive partition writer write block to file. #32775

Merged

Conversation

kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Mar 25, 2024

Proposed changes

Issue Number: #31442

Fix the issue of block was not copied to do filtering when hive partition writer write block to file.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

…ing when hive partition writer write block to file.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaka11chen
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38284 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 49de1201402753a483cb367dc5a80622038dc291, data reload: false

------ Round 1 ----------------------------------
q1	17619	4294	4115	4115
q2	2111	156	169	156
q3	10560	1252	1220	1220
q4	11085	749	790	749
q5	7450	3035	3008	3008
q6	206	125	121	121
q7	1035	581	574	574
q8	9606	2056	2041	2041
q9	7487	6701	6697	6697
q10	8460	3468	3582	3468
q11	435	226	213	213
q12	370	200	192	192
q13	17798	2836	2865	2836
q14	225	204	210	204
q15	507	455	456	455
q16	487	378	367	367
q17	959	525	628	525
q18	7226	6614	6415	6415
q19	1571	1489	1425	1425
q20	554	249	264	249
q21	3559	2967	3022	2967
q22	352	287	287	287
Total cold run time: 109662 ms
Total hot run time: 38284 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4083	4069	4077	4069
q2	330	219	228	219
q3	2975	2816	2863	2816
q4	1877	1561	1511	1511
q5	5292	5322	5382	5322
q6	198	114	116	114
q7	2225	1873	1849	1849
q8	3189	3291	3323	3291
q9	8731	8679	8692	8679
q10	3816	3769	3785	3769
q11	547	452	440	440
q12	724	535	537	535
q13	16929	2852	2846	2846
q14	274	241	264	241
q15	499	450	456	450
q16	466	425	419	419
q17	1724	1486	1483	1483
q18	7503	7176	7217	7176
q19	1625	1486	1463	1463
q20	1907	1726	1697	1697
q21	4879	4768	4686	4686
q22	521	443	449	443
Total cold run time: 70314 ms
Total hot run time: 53518 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.25% (8732/24769)
Line Coverage: 27.06% (71522/264338)
Region Coverage: 26.29% (37108/141123)
Branch Coverage: 23.19% (18979/81834)
Coverage Report: http://coverage.selectdb-in.cc/coverage/49de1201402753a483cb367dc5a80622038dc291_49de1201402753a483cb367dc5a80622038dc291/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 185967 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 49de1201402753a483cb367dc5a80622038dc291, data reload: false

query1	940	364	357	357
query2	7390	2185	2005	2005
query3	6714	201	208	201
query4	32065	21302	21202	21202
query5	4319	405	449	405
query6	271	175	179	175
query7	4629	285	291	285
query8	232	173	182	173
query9	9025	2266	2269	2266
query10	574	243	260	243
query11	15554	14470	14491	14470
query12	138	93	87	87
query13	1632	416	407	407
query14	12236	10684	11132	10684
query15	271	220	200	200
query16	7908	256	258	256
query17	1997	576	552	552
query18	1518	295	280	280
query19	335	156	152	152
query20	94	89	87	87
query21	203	129	127	127
query22	5057	4853	4830	4830
query23	33408	32811	32621	32621
query24	10770	2900	2814	2814
query25	623	385	387	385
query26	1326	155	157	155
query27	2814	348	352	348
query28	7534	1882	1870	1870
query29	895	664	621	621
query30	305	150	151	150
query31	964	742	730	730
query32	101	59	56	56
query33	767	262	255	255
query34	1053	476	481	476
query35	805	613	595	595
query36	1015	841	859	841
query37	132	77	76	76
query38	3512	3446	3442	3442
query39	1507	1414	1405	1405
query40	211	110	112	110
query41	54	47	48	47
query42	102	99	101	99
query43	480	457	450	450
query44	1151	699	707	699
query45	269	267	260	260
query46	1120	694	692	692
query47	1934	1852	1838	1838
query48	442	355	351	351
query49	1120	342	344	342
query50	760	372	368	368
query51	6698	6602	6541	6541
query52	108	94	92	92
query53	340	276	274	274
query54	309	233	242	233
query55	83	80	82	80
query56	257	248	243	243
query57	1222	1135	1153	1135
query58	232	215	206	206
query59	2826	2579	2584	2579
query60	296	256	256	256
query61	113	115	117	115
query62	661	451	463	451
query63	315	277	280	277
query64	5904	3917	4046	3917
query65	3062	2997	3012	2997
query66	1325	364	359	359
query67	15676	14961	15033	14961
query68	9520	518	531	518
query69	700	375	373	373
query70	1405	1123	1119	1119
query71	536	276	274	274
query72	7114	2733	2556	2556
query73	1595	319	307	307
query74	8651	6659	6687	6659
query75	4983	2784	2762	2762
query76	6056	925	913	913
query77	790	261	265	261
query78	10864	10222	10056	10056
query79	11068	527	520	520
query80	1503	412	393	393
query81	508	215	221	215
query82	359	209	200	200
query83	226	152	146	146
query84	290	77	77	77
query85	1243	342	317	317
query86	351	302	291	291
query87	3711	3518	3531	3518
query88	5211	2275	2276	2275
query89	497	393	377	377
query90	2319	179	174	174
query91	177	141	137	137
query92	61	45	48	45
query93	6539	493	482	482
query94	1553	177	179	177
query95	438	329	327	327
query96	620	268	263	263
query97	3079	2903	2883	2883
query98	222	206	205	205
query99	1109	926	891	891
Total cold run time: 321001 ms
Total hot run time: 185967 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 49de1201402753a483cb367dc5a80622038dc291 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 25, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 7169c07 into apache:master Mar 25, 2024
28 of 32 checks passed
kaka11chen added a commit to kaka11chen/doris that referenced this pull request Apr 9, 2024
…ing when hive partition writer write block to file. (apache#32775)
kaka11chen added a commit to kaka11chen/doris that referenced this pull request Apr 9, 2024
…ing when hive partition writer write block to file. (apache#32775)
morningman pushed a commit that referenced this pull request Apr 9, 2024
…ing when hive partition writer write block to file. (#32775) (#33447)

backport #32775
yiguolei pushed a commit that referenced this pull request Apr 10, 2024
…ing when hive partition writer write block to file. (#32775) (#33447)

backport #32775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants