Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](profile) Disable show query/load profile stmt #32467

Merged
merged 4 commits into from
Mar 26, 2024
Merged

[opt](profile) Disable show query/load profile stmt #32467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
868470d
WIP
zhiqiang-hhhh Mar 19, 2024
b80ea1c
FORMAT
zhiqiang-hhhh Mar 19, 2024
1e85088
FORMAT
zhiqiang-hhhh Mar 19, 2024
fec12f6
Merge branch 'master' into profile-disable-show
zhiqiang-hhhh Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 14 additions & 124 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/ShowLoadProfileStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,142 +17,32 @@

package org.apache.doris.analysis;

import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.ScalarType;
import org.apache.doris.common.AnalysisException;
import org.apache.doris.catalog.Env;
import org.apache.doris.common.Config;
import org.apache.doris.common.UserException;
import org.apache.doris.qe.ShowResultSetMetaData;

import com.google.common.base.Strings;

// For stmt like:
// show load profile "/"; # list all saving load job ids
// show load profile "/e0f7390f5363419e-xxx" # show task ids of specified job
// show load profile "/e0f7390f5363419e-xxx/e0f7390f5363419e-yyy/" # show instance list of the task
// show load profile "/e0f7390f5363419e-xxx/e0f7390f5363419e-yyy/e0f7390f5363419e-zzz" # show instance's graph
// deprecated stmt, use will be guided to a specific url to get profile from
// web browser
public class ShowLoadProfileStmt extends ShowStmt {
private static final ShowResultSetMetaData META_DATA_TASK_IDS =
ShowResultSetMetaData.builder()
.addColumn(new Column("TaskId", ScalarType.createVarchar(128)))
.addColumn(new Column("ActiveTime", ScalarType.createVarchar(64)))
.build();

public enum PathType {
QUERY_IDS,
TASK_IDS,
FRAGMENTS,
INSTANCES,
SINGLE_INSTANCE
}

private String idPath;
private PathType pathType;

private String jobId = "";
private String taskId = "";
private String fragmentId = "";
private String instanceId = "";

public ShowLoadProfileStmt(String idPath) {
this.idPath = idPath;
}

public PathType getPathType() {
return pathType;
}

public String getJobId() {
return jobId;
}

public String getTaskId() {
return taskId;
}
private String loadIdPath;

public String getFragmentId() {
return fragmentId;
}

public String getInstanceId() {
return instanceId;
public ShowLoadProfileStmt(String path) {
this.loadIdPath = path;
}

@Override
public void analyze(Analyzer analyzer) throws UserException {
super.analyze(analyzer);
if (Strings.isNullOrEmpty(idPath)) {
// list all query ids
pathType = PathType.QUERY_IDS;
return;
}

if (!idPath.startsWith("/")) {
throw new AnalysisException("Path must starts with '/'");
}
pathType = PathType.QUERY_IDS;
String[] parts = idPath.split("/");
if (parts.length > 5) {
throw new AnalysisException("Path must in format '/jobId/taskId/fragmentId/instanceId'");
}

for (int i = 0; i < parts.length; i++) {
switch (i) {
case 0:
pathType = PathType.QUERY_IDS;
continue;
case 1:
jobId = parts[i];
pathType = PathType.TASK_IDS;
break;
case 2:
taskId = parts[i];
pathType = PathType.FRAGMENTS;
break;
case 3:
fragmentId = parts[i];
pathType = PathType.INSTANCES;
break;
case 4:
instanceId = parts[i];
pathType = PathType.SINGLE_INSTANCE;
break;
default:
break;
}
}
}

@Override
public String toSql() {
StringBuilder sb = new StringBuilder("SHOW LOAD PROFILE ").append(idPath);
return sb.toString();
}

@Override
public String toString() {
return toSql();
String selfHost = Env.getCurrentEnv().getSelfNode().getHost();
int httpPort = Config.http_port;
String terminalMsg = String.format(
"try visit http://%s:%d/QueryProfile/%s, show query/load profile syntax is a deprecated feature",
selfHost, httpPort, this.loadIdPath);
throw new UserException(terminalMsg);
}

@Override
public ShowResultSetMetaData getMetaData() {
switch (pathType) {
case QUERY_IDS:
return ShowQueryProfileStmt.META_DATA_QUERY_IDS;
case TASK_IDS:
return META_DATA_TASK_IDS;
case FRAGMENTS:
return ShowQueryProfileStmt.META_DATA_FRAGMENTS;
case INSTANCES:
return ShowQueryProfileStmt.META_DATA_INSTANCES;
case SINGLE_INSTANCE:
return ShowQueryProfileStmt.META_DATA_SINGLE_INSTANCE;
default:
return null;
}
}

@Override
public RedirectStatus getRedirectStatus() {
return RedirectStatus.FORWARD_NO_SYNC;
return null;
}
}
136 changes: 11 additions & 125 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/ShowQueryProfileStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,146 +17,32 @@

package org.apache.doris.analysis;

import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.ScalarType;
import org.apache.doris.common.AnalysisException;
import org.apache.doris.catalog.Env;
import org.apache.doris.common.Config;
import org.apache.doris.common.UserException;
import org.apache.doris.common.profile.SummaryProfile;
import org.apache.doris.qe.ShowResultSetMetaData;

import com.google.common.base.Strings;

// For stmt like:
// show query profile "/"; # list all saving query ids
// show query profile "/e0f7390f5363419e-b416a2a79996083e" # show graph of fragments of the query
// show query profile "/e0f7390f5363419e-b416a2a79996083e/0" # show instance list of the specified fragment
// show query profile "/e0f7390f5363419e-b416a2a79996083e/0/e0f7390f5363419e-b416a2a799960906" # show instance's graph
// deprecated stmt, use will be guided to a specific url to get profile from
// web browser
public class ShowQueryProfileStmt extends ShowStmt {
// This should be same as ProfileManager.PROFILE_HEADERS
public static final ShowResultSetMetaData META_DATA_QUERY_IDS;

public static final ShowResultSetMetaData META_DATA_FRAGMENTS =
ShowResultSetMetaData.builder()
.addColumn(new Column("Fragments", ScalarType.createVarchar(65535)))
.build();
public static final ShowResultSetMetaData META_DATA_INSTANCES =
ShowResultSetMetaData.builder()
.addColumn(new Column("Instances", ScalarType.createVarchar(128)))
.addColumn(new Column("Host", ScalarType.createVarchar(64)))
.addColumn(new Column("ActiveTime", ScalarType.createVarchar(64)))
.build();
public static final ShowResultSetMetaData META_DATA_SINGLE_INSTANCE =
ShowResultSetMetaData.builder()
.addColumn(new Column("Instance", ScalarType.createVarchar(65535)))
.build();

static {
ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder();
for (String key : SummaryProfile.SUMMARY_KEYS) {
builder.addColumn(new Column(key, ScalarType.createStringType()));
}
META_DATA_QUERY_IDS = builder.build();
}

public enum PathType {
QUERY_IDS,
FRAGMENTS,
INSTANCES,
SINGLE_INSTANCE
}

private String queryIdPath;
private PathType pathType;

private String queryId = "";
private String fragmentId = "";
private String instanceId = "";

public ShowQueryProfileStmt(String queryIdPath) {
this.queryIdPath = queryIdPath;
}

public PathType getPathType() {
return pathType;
}

public String getQueryId() {
return queryId;
}

public String getFragmentId() {
return fragmentId;
}

public String getInstanceId() {
return instanceId;
}

@Override
public void analyze(Analyzer analyzer) throws UserException {
super.analyze(analyzer);
if (Strings.isNullOrEmpty(queryIdPath)) {
// list all query ids
pathType = PathType.QUERY_IDS;
return;
}

if (!queryIdPath.startsWith("/")) {
throw new AnalysisException("Query path must starts with '/'");
}
pathType = PathType.QUERY_IDS;
String[] parts = queryIdPath.split("/");
if (parts.length > 4) {
throw new AnalysisException("Query path must in format '/queryId/fragmentId/instanceId'");
}

for (int i = 0; i < parts.length; i++) {
switch (i) {
case 0:
pathType = PathType.QUERY_IDS;
continue;
case 1:
queryId = parts[i];
pathType = PathType.FRAGMENTS;
break;
case 2:
fragmentId = parts[i];
pathType = PathType.INSTANCES;
break;
case 3:
instanceId = parts[i];
pathType = PathType.SINGLE_INSTANCE;
break;
default:
break;
}
}
}

@Override
public String toSql() {
StringBuilder sb = new StringBuilder("SHOW QUERY PROFILE ").append(queryIdPath);
return sb.toString();
}

@Override
public String toString() {
return toSql();
String selfHost = Env.getCurrentEnv().getSelfNode().getHost();
int httpPort = Config.http_port;
String terminalMsg = String.format(
"try visit http://%s:%d/QueryProfile/%s, show query/load profile syntax is a deprecated feature",
selfHost, httpPort, this.queryIdPath);
throw new UserException(terminalMsg);
}

@Override
public ShowResultSetMetaData getMetaData() {
switch (pathType) {
case QUERY_IDS:
return META_DATA_QUERY_IDS;
case FRAGMENTS:
return META_DATA_FRAGMENTS;
case INSTANCES:
return META_DATA_INSTANCES;
case SINGLE_INSTANCE:
return META_DATA_SINGLE_INSTANCE;
default:
return null;
}
return null;
}
}
Loading
Loading