[Fix](Variant) fix variant with not null #32248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
ignore null bitmap for not null and make subcolumn access slots always nullable
eldenmoon
force-pushed
the
fix-var-not-null
branch
from
b669057
to
f1f5f1d
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38275 ms |
morrySnow
requested changes
Mar 15, 2024
| slotDescriptor.setMaterializedColumnName(slotRef.getColumnName() | ||
| + "." + String.join(".", slotReference.getSubColPath())); | ||
| // always nullable at present | ||
| slotDescriptor.setIsNullable(true); |
There was a problem hiding this comment.
if variant slot always nullable, u should set it correctly in Nereids, because nereids need nullable info todo some optimization. if u set uncorrect nullable info, we will get wrong plan sometimes
|
run buildall |
TPC-H: Total hot run time: 38316 ms |
|
TeamCity be ut coverage result: |
morrySnow
approved these changes
Mar 18, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run p0 |
yiguolei
pushed a commit
that referenced
this pull request
Mar 21, 2024
ignore null bitmap for not null and make subcolumn access slots always nullable
yiguolei
pushed a commit
that referenced
this pull request
Mar 21, 2024
ignore null bitmap for not null and make subcolumn access slots always nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore null bitmap for not null and make subcolumn access slots always nullable
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...