[enhance](mtmv)Mtmv rollup #31812
Merged
[enhance](mtmv)Mtmv rollup #31812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
|
run buildall |
|
check null partition is correct in the partition roll up scene |
seawinde
approved these changes
May 8, 2024
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
run buildall |
morrySnow
reviewed
May 10, 2024
...rc/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java
Show resolved
Hide resolved
...rc/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVRelatedPartitionDescRollUpGenerator.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionExprDateTrunc.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionExprDateTrunc.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionUtil.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java
Show resolved
Hide resolved
|
run buildall |
morrySnow
approved these changes
May 14, 2024
Comment on lines
+229
to
+230
| : partitionKey = identifier | ||
| | partitionExpr = functionCallExpression |
There was a problem hiding this comment.
nit: u could write like
Suggested change
| : partitionKey = identifier | |
| | partitionExpr = functionCallExpression | |
| : identifier #partitionKey | |
| | functionCallExpression partitionExpr |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
1 similar comment
|
PR approved by at least one committer and no changes requested. |
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
if create MTMV `date_trunc(`xxx`,'month')` when related table is `range` partition,and have 3 partitions: ``` 20200101-20200102 20200102-20200103 20200201-20200202 ``` then MTMV will have 2 partitions: ``` 20200101-20200201 20200201-20200301 ``` when related table is `list` partition,and have 3 partitions: ``` (20200101,20200102) (20200103) (20200201) ``` then MTMV will have 2 partitions: ``` (20200101,20200102，20200103) (20200201) ```
yiguolei
pushed a commit
that referenced
this pull request
May 18, 2024
if create MTMV `date_trunc(`xxx`,'month')` when related table is `range` partition,and have 3 partitions: ``` 20200101-20200102 20200102-20200103 20200201-20200202 ``` then MTMV will have 2 partitions: ``` 20200101-20200201 20200201-20200301 ``` when related table is `list` partition,and have 3 partitions: ``` (20200101,20200102) (20200103) (20200201) ``` then MTMV will have 2 partitions: ``` (20200101,20200102，20200103) (20200201) ```
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
if create MTMV
date_trunc(xxx,'month')when related table is
rangepartition,and have 3 partitions:then MTMV will have 2 partitions:
when related table is
listpartition,and have 3 partitions:then MTMV will have 2 partitions:
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...