[fix](hive) support partition prune for _HIVE_DEFAULT_PARTITION_ #31736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starocean999
approved these changes
Mar 4, 2024
morningman
changed the title
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
morrySnow
approved these changes
Mar 5, 2024
zddr
reviewed
Mar 5, 2024
| // If any partition key is hive default partition, return true. | ||
| // Only used for hive table. | ||
| public boolean isHiveDefaultPartition() { | ||
| for (PartitionKey partitionKey : partitionKeys) { |
There was a problem hiding this comment.
isDefaultPartition() not need delete?
There was a problem hiding this comment.
No, isDefaultPartition() is for other cases.
"default" partition is not "null" partition.
the _HIVE_DEFAULT_PARTITION_ is actually "null" partition in Doris
zddr
approved these changes
Mar 5, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 6, 2024
) This PR #23026 support the partition prune for hive table with `_HIVE_DEFAULT_PARTITION`, but it will always select partition with `_HIVE_DEFAULT_PARTITION`. This PR #31613 support null partition for olap table's list partition, so we can treat `_HIVE_DEFAULT_PARTITION` as null partition of hive table. So this PR change the partition prune logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR #23026 support the partition prune for hive table with
_HIVE_DEFAULT_PARTITION,but it will always select partition with
_HIVE_DEFAULT_PARTITION.This PR #31613 support null partition for olap table's list partition, so we can treat
_HIVE_DEFAULT_PARTITIONas null partition of hive table.
So this PR change the partition prune logic
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...