Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](insert)add hive table sink definition #31662

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

wsjz
Copy link
Contributor

@wsjz wsjz commented Mar 1, 2024

Proposed changes

issue: #31442

define hive table sink thrift and framework.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Copy link
Contributor

github-actions bot commented Mar 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@wsjz wsjz force-pushed the init_hive_sink branch 2 times, most recently from a15b457 to dafb315 Compare March 3, 2024 18:35
Copy link
Contributor

github-actions bot commented Mar 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Mar 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@wsjz
Copy link
Contributor Author

wsjz commented Mar 4, 2024

run buildall

@wsjz wsjz marked this pull request as ready for review March 4, 2024 01:16
@wsjz
Copy link
Contributor Author

wsjz commented Mar 4, 2024

run buildall

Copy link
Contributor

github-actions bot commented Mar 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@wsjz
Copy link
Contributor Author

wsjz commented Mar 4, 2024

run buildall

Copy link
Contributor

github-actions bot commented Mar 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

morningman
morningman previously approved these changes Mar 4, 2024
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Mar 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

PR approved by anyone and no changes requested.

@wsjz wsjz changed the title [featurl](insert)add hive table sink definition [feature](insert)add hive table sink definition Mar 4, 2024
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wsjz
Copy link
Contributor Author

wsjz commented Mar 4, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@wsjz
Copy link
Contributor Author

wsjz commented Mar 4, 2024

run buildall

Copy link
Contributor

github-actions bot commented Mar 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@wsjz
Copy link
Contributor Author

wsjz commented Mar 4, 2024

run p0

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit da5b6d3 into apache:master Mar 5, 2024
24 of 28 checks passed
morningman pushed a commit to morningman/doris that referenced this pull request Mar 17, 2024
define hive table sink thrift and framework.
morningman added a commit that referenced this pull request Mar 17, 2024
@wsjz wsjz deleted the init_hive_sink branch March 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.1-merged meta-change reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants