Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equal conjuncts which refer more than two tuples registered unsuccessfully #266

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Conversation

chenhao7253886
Copy link
Contributor

Change-Id: I7eaf28ee6db35671971108f3edefe908d46ae87f

Change-Id: I7eaf28ee6db35671971108f3edefe908d46ae87f
@chenhao7253886 chenhao7253886 changed the title fail to register equal conjuncts which refer more than three tuples fail to register equal conjuncts which refer more than two tuples Nov 1, 2018
@chenhao7253886 chenhao7253886 changed the title fail to register equal conjuncts which refer more than two tuples fix equal conjuncts which refer more than two tuples registeredunsuccessfully Nov 1, 2018
@chenhao7253886 chenhao7253886 added the kind/fix Categorizes issue or PR as related to a bug. label Nov 1, 2018
@chenhao7253886 chenhao7253886 changed the title fix equal conjuncts which refer more than two tuples registeredunsuccessfully fix equal conjuncts which refer more than two tuples registered unsuccessfully Nov 1, 2018
@chenhao7253886 chenhao7253886 changed the title fix equal conjuncts which refer more than two tuples registered unsuccessfully Fix equal conjuncts which refer more than two tuples registered unsuccessfully Nov 1, 2018
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -767,7 +767,6 @@ private void registerConjunct(Expr e) {
ArrayList<TupleId> tupleIds = Lists.newArrayList();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit log format is wrong.

@morningman morningman merged commit ad12d90 into apache:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants