Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) colocate join could not work well on full outer join #24700

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[fix](Nereids) colocate join could not work well on full outer join #24700

merged 1 commit into from
Sep 21, 2023

Conversation

morrySnow
Copy link
Contributor

in previous PR #22979, we fix the output deriver of join. But we forgot to change the util method JoinUtils#shouldColocateJoin to adjust the change of physical properties derive.
we could not use join distribution type anymore since join could output any distribute for full outer join.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
[fix](Nereids) colocate join could not work well on full outer join
d8bde39 
in previous PR apache#22979, we fix the output deriver of join. But we forgot
to change the util method JoinUtils#shouldColocateJoin to adjust the
change of physical properties derive.
we could not use join distribution type anymore since join could output
any distribute for full outer join.
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.75 seconds
stream load tsv: 612 seconds loaded 74807831229 Bytes, about 116 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162313624 Bytes

wm1581066
wm1581066 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@wm1581066 wm1581066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@morrySnow morrySnow merged commit ce57b99 into apache:master Sep 21, 2023
16 of 17 checks passed
xiaokang pushed a commit that referenced this pull request Sep 21, 2023
@morrySnow @xiaokang
[fix](Nereids) colocate join could not work well on full outer join (#…
be3d31e 
…24700)

in previous PR #22979, we fix the output deriver of join. But we forgot
to change the util method JoinUtils#shouldColocateJoin to adjust the
change of physical properties derive.
we could not use join distribution type anymore since join could output
any distribute for full outer join.
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
Open
@morrySnow morrySnow deleted the fix_colocate_join_bug branch October 10, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wm1581066 wm1581066 wm1581066 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @doris-robot @starocean999 @wm1581066 @xiaokang