Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](view) The parameter positions of timestamp diff function to sql are reversed #23601

Merged
merged 1 commit into from
Aug 29, 2023
Merged

[fix](view) The parameter positions of timestamp diff function to sql are reversed #23601

merged 1 commit into from
Aug 29, 2023

Conversation

morrySnow
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.92 seconds
stream load tsv: 537 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162096186 Bytes

@yiguolei yiguolei added the usercase Important user case type label label Aug 29, 2023
xiaokang
xiaokang approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 29, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit cc1509b into apache:master Aug 29, 2023
17 of 18 checks passed
@morrySnow morrySnow deleted the fix_xx_diff_func branch August 29, 2023 10:30
xiaokang pushed a commit that referenced this pull request Aug 29, 2023
@morrySnow @xiaokang
[fix](view) The parameter positions of timestamp diff function to sql…
89736fe 
… are reversed (#23601)
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Open
xiaokang pushed a commit that referenced this pull request Aug 30, 2023
@morrySnow @xiaokang
[fix](view) The parameter positions of timestamp diff function to sql…
9c3ee8d 
… are reversed (#23601)
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
Open
@xiaokang xiaokang mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@xiaokang xiaokang xiaokang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged dev/2.0.2-merged merge_conflict p0_w reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morrySnow @hello-stephen @xiaokang @yiguolei