Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Outfile/Nereids) fix that csv_with_names and csv_with_names_and_types file format could not be exported on nereids #23387

Merged
merged 2 commits into from
Aug 25, 2023
Merged

[fix](Outfile/Nereids) fix that csv_with_names and csv_with_names_and_types file format could not be exported on nereids #23387

merged 2 commits into from
Aug 25, 2023

Conversation

BePPPower
Copy link
Contributor

@BePPPower BePPPower commented Aug 23, 2023 •
edited
Loading

Proposed changes

Issue Number: close #xxx

This problem is casued by #21197

Fixed an issue that csv_with_names and csv_with_names_and_types file format could not be exported on nereids optimizer when using select...into outfile.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@BePPPower
Copy link
Contributor Author

run buildall

@BePPPower
Copy link
Contributor Author

run buildall

1 similar comment
@BePPPower
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.76 seconds
stream load tsv: 543 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162195181 Bytes

morningman
morningman approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 24, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

wsjz
wsjz approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@wsjz wsjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 1809451 into apache:master Aug 25, 2023
18 of 19 checks passed
xiaokang pushed a commit that referenced this pull request Aug 25, 2023
@BePPPower @xiaokang
[fix](Outfile/Nereids) fix that csv_with_names and `csv_with_names_…
fa3cd04 
…and_types` file format could not be exported on nereids (#23387)

This problem is casued by #21197

Fixed an issue that `csv_with_names` and `csv_with_names_and_types` file format could not be exported on nereids optimizer when using `select...into outfile`.
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsjz wsjz wsjz approved these changes

@zddr zddr zddr approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged p1_query_exception reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BePPPower @hello-stephen @morningman @zddr @wsjz @xiaokang