[fix](Nereids) use Stopwatch as timeout checker #23383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. avoid thread leak if exception thrown in planning 2. avoid memory release delays since the timer task hold CascadesContext object
morrySnow
force-pushed
the
fix_thread_leak
branch
from
6a79ec7 to
306bf5c
Compare
|
run buildall |
morrySnow
changed the title
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
starocean999
approved these changes
Aug 23, 2023
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xiaokang
pushed a commit
that referenced
this pull request
Aug 24, 2023
1. avoid thread leak if exception thrown in planning 2. avoid memory release delays since the timer task hold CascadesContext object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...