Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement](inverted index) remove time-consuming log prints in bkd reader #23381

Merged
merged 2 commits into from
Aug 23, 2023
Merged

[Enhancement](inverted index) remove time-consuming log prints in bkd reader #23381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f56ca6
enhance bkd stats print
airborne12 Aug 23, 2023
47f6cb1
format
Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions be/src/olap/rowset/segment_v2/inverted_index_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,6 @@ Status BkdIndexReader::bkd_query(OlapReaderStatistics* stats, const std::string&
Status BkdIndexReader::try_query(OlapReaderStatistics* stats, const std::string& column_name,
const void* query_value, InvertedIndexQueryType query_type,
uint32_t* count) {
uint64_t start = UnixMillis();
auto visitor = std::make_unique<InvertedIndexVisitor>(nullptr, query_type, true);
std::shared_ptr<lucene::util::bkd::bkd_reader> r;
try {
Expand All @@ -631,8 +630,7 @@ Status BkdIndexReader::try_query(OlapReaderStatistics* stats, const std::string&
"BKD Query CLuceneError Occurred, error msg: {}", e.what());
}

LOG(INFO) << "BKD index try search time taken: " << UnixMillis() - start << "ms "
<< " column: " << column_name << " result: " << *count;
VLOG_DEBUG << "BKD index try search column: " << column_name << " result: " << *count;
return Status::OK();
}

Expand Down Expand Up @@ -662,11 +660,9 @@ Status BkdIndexReader::query(OlapReaderStatistics* stats, const std::string& col
// stats->inverted_index_query_cache_miss++;
// }

uint64_t start = UnixMillis();
auto visitor = std::make_unique<InvertedIndexVisitor>(bit_map, query_type);
std::shared_ptr<lucene::util::bkd::bkd_reader> r;
try {
SCOPED_RAW_TIMER(&stats->inverted_index_searcher_search_timer);
auto st = bkd_query(stats, column_name, query_value, query_type, r, visitor.get());
if (!st.ok()) {
if (st.code() == ErrorCode::END_OF_FILE) {
Expand All @@ -686,9 +682,8 @@ Status BkdIndexReader::query(OlapReaderStatistics* stats, const std::string& col
// term_match_bitmap->runOptimize();
// cache->insert(cache_key, term_match_bitmap, &cache_handle);

LOG(INFO) << "BKD index search time taken: " << UnixMillis() - start << "ms "
<< " column: " << column_name << " result: " << bit_map->cardinality()
<< " reader stats: " << r->stats.to_string();
VLOG_DEBUG << "BKD index search column: " << column_name
<< " result: " << bit_map->cardinality();
return Status::OK();
}

Expand Down