Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement](pipeline) Terminate early for short-circuit join #23378

Merged
merged 2 commits into from
Aug 23, 2023
Merged

[Improvement](pipeline) Terminate early for short-circuit join #23378

merged 2 commits into from
Aug 23, 2023

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Aug 23, 2023 •
edited
Loading

Proposed changes

image

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.35 seconds
stream load tsv: 541 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162012519 Bytes

@yiguolei yiguolei added dev/2.0.1 usercase Important user case type label labels Aug 23, 2023
HappenLee
HappenLee approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 23, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 9d1f2cd into apache:master Aug 23, 2023
18 of 19 checks passed
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Aug 23, 2023
@Gabriel39
[Improvement](pipeline) Terminate early for short-circuit join (apach…
b918840 
…e#23378)
@Gabriel39 Gabriel39 mentioned this pull request Aug 23, 2023
Merged
xiaokang pushed a commit that referenced this pull request Aug 24, 2023
@Gabriel39
[Improvement](pipeline) Terminate early for short-circuit join (#23378)…
725811e 
… (#23396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gabriel39 @hello-stephen @yiguolei @HappenLee @xiaokang