Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](planner) fix current_timestamp param type mismatch when doing stream load #23092

Merged
merged 3 commits into from
Aug 18, 2023
Merged

[fix](planner) fix current_timestamp param type mismatch when doing stream load #23092

merged 3 commits into from
Aug 18, 2023

Conversation

TangSiyang2001
Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 commented Aug 17, 2023 •
edited
Loading

Proposed changes

Issue Number: close #23013

FileLoadScanNode did not analyze the default value expr, result in target param type int32 become int8 as the original IntLiteral type.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@TangSiyang2001 TangSiyang2001 changed the title [fix](planner) fix current_timestamp with precision param type failed to cast [fix](planner) fix current_timestamp param type failed to cast Aug 17, 2023
@TangSiyang2001 TangSiyang2001 changed the title [fix](planner) fix current_timestamp param type failed to cast [fix](planner) fix current_timestamp param type mismatch Aug 17, 2023
@TangSiyang2001
Copy link
Collaborator Author

run buildall

@TangSiyang2001 TangSiyang2001 changed the title [fix](planner) fix current_timestamp param type mismatch [fix](planner) fix current_timestamp param type mismatch when doing stream load Aug 17, 2023
@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.94 seconds
stream load tsv: 511 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162159220 Bytes

@dataroaring dataroaring added dev/2.0.1 usercase Important user case type label labels Aug 17, 2023
@BiteTheDDDDt
Copy link
Contributor

run p0

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Aug 17, 2023
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt
Copy link
Contributor

run p0

@TangSiyang2001
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 17, 2023
@TangSiyang2001
Copy link
Collaborator Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.68 seconds
stream load tsv: 541 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162337505 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 18, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit a7771ea into apache:master Aug 18, 2023
16 of 17 checks passed
yiguolei pushed a commit that referenced this pull request Aug 18, 2023
@TangSiyang2001 @Doris-Extras
[fix](planner) fix current_timestamp param type mismatch when doing s…
2613857 
…tream load (#23092)

FileLoadScanNode did not analyze the default value expr, result in target param type int32 become int8 as the original IntLiteral type.
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Aug 21, 2023
@TangSiyang2001 @airborne12
[fix](planner) fix current_timestamp param type mismatch when doing s…
5499e0a 
…tream load (apache#23092)

FileLoadScanNode did not analyze the default value expr, result in target param type int32 become int8 as the original IntLiteral type.
@TangSiyang2001 TangSiyang2001 mentioned this pull request Aug 24, 2023
Merged
@zy-kkk zy-kkk mentioned this pull request Aug 24, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TangSiyang2001 @hello-stephen @BiteTheDDDDt @dataroaring @yiguolei