-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Nereids) type check could not work when root node is table or file sink #22902
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
8d653a9
to
db1864f
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
db1864f
to
7d5235b
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by anyone and no changes requested. |
PR approved by at least one committer and no changes requested. |
…ile sink (apache#22902) type check could not work because no expression in plan. sink and scan have no expression at all. so cannot check type. this pr add expression on logical sink to let type check work well
Proposed changes
Issue Number: close #xxx
type check could not work because no expression in plan
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...