Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment v2 use string's real length(#1943) #1944

Merged
merged 4 commits into from
Oct 13, 2019
Merged

Segment v2 use string's real length(#1943) #1944

merged 4 commits into from
Oct 13, 2019

Conversation

wangbo
Copy link
Contributor

@wangbo wangbo commented Oct 9, 2019

imay
imay requested changes Oct 10, 2019
View reviewed changes
be/src/olap/field.h Outdated Show resolved Hide resolved
be/src/olap/field.h Outdated Show resolved Hide resolved
be/src/olap/field.h Outdated Show resolved Hide resolved
be/src/olap/field.h Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/segment_writer.cpp Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/segment_writer.cpp Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/column_writer.cpp Outdated Show resolved Hide resolved
@wangbo wangbo closed this Oct 12, 2019
@wangbo wangbo reopened this Oct 12, 2019
imay
imay reviewed Oct 12, 2019
View reviewed changes
be/src/olap/field.h Outdated Show resolved Hide resolved
be/src/olap/field.h Outdated Show resolved Hide resolved
be/src/olap/types.h Show resolved Hide resolved
@wangbo
1. set type<char/varchar> set_to_max to nullptr
aba3b58 
2. change allocate_memory comment
3. remove allocate_value_from_arena from type.h
imay
imay approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit 80e9b21 into apache:master Oct 13, 2019
xy720 pushed a commit to xy720/doris that referenced this pull request Oct 18, 2019
@wangbo
Make Segment v2 use string's real length(apache#1943) (apache#1944)
aa5ea6e
wuyunfeng pushed a commit to wuyunfeng/incubator-doris that referenced this pull request Oct 22, 2019
@wangbo @wuyunfeng
Make Segment v2 use string's real length(apache#1943) (apache#1944)
a7b3e2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangbo @imay