Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](FE) fix compile error due to code refactor #15192

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Dec 20, 2022

Proposed changes

Issue Number: close #xxx
#15157 and #14827 together would bring fe compile error due to failed to find symbol cause there is no build() in CheckAnalysis, it's buildRules() instead.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 20, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.97 seconds
load time: 660 seconds
storage size: 17123601055 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221220050309_clickbench_pr_65409.html

@Gabriel39 Gabriel39 changed the title [Buf](FE) fix compile error due to code refactor [Bug](FE) fix compile error due to code refactor Dec 20, 2022
@Gabriel39 Gabriel39 merged commit 737fe49 into apache:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/nereids reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants