[Opt](Vectorized) Support push down no grouping agg #12803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/planner
| dst->insert_data(sv->ptr, sv->len); | ||
| } else { | ||
| dst->insert_many_fix_len_data(static_cast<const char*>(max_value->cell_ptr()), 1); | ||
| } |
There was a problem hiding this comment.
why not just use insert_data here?
There was a problem hiding this comment.
may have uint24_t use in Date , insert_data may cause bug.
| // TODO: the work may cause performance problem, opt latter | ||
| for (int i = 0; i < size; ++i) { | ||
| dst->insert_many_fix_len_data(static_cast<const char*>(min_value->cell_ptr()), 1); | ||
| } |
There was a problem hiding this comment.
Maybe we can use insert_many_fix_len_data( ,size)
There was a problem hiding this comment.
en，just add a todo here to support in the future
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
Support push down no grouping agg
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
Support push down no grouping agg
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
Support push down no grouping agg
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
Support push down no grouping agg
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
Support push down no grouping agg
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
Support push down no grouping agg
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use the segment static to speed up some not grouping agg query：
min,max,countHere need to a new SegmentIter call
StatisticsIterto do the work.lineorder : 60kw line num
query Before After
count(*) 0.5s 0.02s
min 0.4s 0.01s
max 0.4s 0.01s
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...