[Improvement](light-schema-change) support tablet schema cache #11131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinyiZzz
reviewed
Jul 22, 2022
Lchangliang
force-pushed
the
opt_schema_memory
branch
from
9295c22
to
bfa3c58
Compare
yiguolei
reviewed
Jul 27, 2022
yiguolei
reviewed
Jul 27, 2022
yiguolei
reviewed
Jul 27, 2022
yiguolei
reviewed
Jul 27, 2022
yiguolei
reviewed
Jul 27, 2022
yiguolei
reviewed
Jul 27, 2022
yiguolei
reviewed
Jul 27, 2022
yiguolei
reviewed
Jul 27, 2022
Lchangliang
force-pushed
the
opt_schema_memory
branch
from
bfa3c58
to
d615a31
Compare
yiguolei
reviewed
Jul 28, 2022
Lchangliang
force-pushed
the
opt_schema_memory
branch
from
d615a31
to
fb2c937
Compare
yiguolei
reviewed
Jul 29, 2022
Lchangliang
force-pushed
the
opt_schema_memory
branch
2 times, most recently
from
9115ecd
to
22a2c13
Compare
13 tasks
Lchangliang
force-pushed
the
opt_schema_memory
branch
2 times, most recently
from
e04c1a8
to
6665995
Compare
Lchangliang
force-pushed
the
opt_schema_memory
branch
from
6665995
to
f918a23
Compare
Lchangliang
changed the title
13 tasks
yiguolei
pushed a commit
that referenced
this pull request
Aug 17, 2022
In engine_clone_task.cpp, it use tablet->tablet_schema() to create rowset, but in the method, it need a lock that already locked in engine_clone_task.cpp:514. It use cloned_tablet_meta->tablet_schema() originally, but modified in #11131. It need to revert to use cloned_tablet_meta->tablet_schema().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
The PR is for #10136. In that, every rowset will presist a tablet schema and use in memory by rowsetMetaPB. But When tablets and rowsets in tablet too more, memory will has a lot of pressure. So we need a way to avoid it.
In this pr, it will implement a global tablet schema cache. Every rowset will hold a tablet schema sptr from cache. That mean even we has tens of thousands of rowsets, if their schema is same, there will be one schema in memory.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...