Skip to content

Commit

Permalink
[fix](planner) Empty table source should not begin a transaction to a…
Browse files Browse the repository at this point in the history
…void infinite transaction (#38991)

## Proposed changes

Issue Number: close #38956 

As title.
  • Loading branch information
TangSiyang2001 authored Aug 7, 2024
1 parent adeae3c commit b7fa6c1
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,10 @@ public AbstractInsertExecutor initPlan(ConnectContext ctx, StmtExecutor executor
// TODO: support other table types
throw new AnalysisException("insert into command only support [olap, hive, iceberg] table");
}

insertExecutor.beginTransaction();
insertExecutor.finalizeSink(planner.getFragments().get(0), sink, physicalSink);
if (!insertExecutor.isEmptyInsert()) {
insertExecutor.beginTransaction();
insertExecutor.finalizeSink(planner.getFragments().get(0), sink, physicalSink);
}
targetTableIf.readUnlock();
} catch (Throwable e) {
targetTableIf.readUnlock();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

suite("test_alter_table_after_empty_insert") {
def tableName = "test_alter_table_after_empty_insert"
sql """ DROP TABLE IF EXISTS ${tableName} """
sql """
CREATE TABLE IF NOT EXISTS ${tableName} (
k BIGINT,
v SMALLINT NOT NULL,
t TEXT NOT NULL
)
DUPLICATE KEY(`k`)
DISTRIBUTED BY HASH(`k`) BUCKETS 4
PROPERTIES("replication_num" = "1")
"""
sql """ INSERT INTO ${tableName} SELECT * FROM ${tableName} """
sql """ ALTER TABLE ${tableName} MODIFY COLUMN v BIGINT AFTER t """
waitForSchemaChangeDone {
sql """ SHOW ALTER TABLE COLUMN WHERE IndexName='${tableName}' ORDER BY createtime DESC LIMIT 1 """
time 60
}
}

0 comments on commit b7fa6c1

Please sign in to comment.