[opt](inverted index) Optimize the compression of inverted index position information #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zzzxl1993
commented
Oct 12, 2024
•
zzzxl1993
commented
- Optimize position information in the inverted index
|
run buildall |
airborne12
reviewed
Oct 12, 2024
|
|
||
| size_t P4DEC(unsigned char *__restrict in, size_t n, uint32_t *__restrict out); | ||
| size_t P4NZDEC(unsigned char *__restrict in, size_t n, uint32_t *__restrict out); | ||
| size_t P4ENC(uint32_t *__restrict in, size_t n, unsigned char *__restrict out); | ||
| size_t P4NZENC(uint32_t *__restrict in, size_t n, unsigned char *__restrict out); | ||
|
|
||
| class PforUtil { | ||
| public: | ||
| static constexpr size_t blockSize = 128; |
There was a problem hiding this comment.
why change block size to 128 from 512?
There was a problem hiding this comment.
blockSize is only used in position compression
| { | ||
| if (!readers.empty()) { | ||
| auto release_readers = [this]() { |
There was a problem hiding this comment.
Release memory in the try->catch->finally code
| @@ -86,6 +87,62 @@ class TermDocsBuffer { | |||
| IndexVersion indexVersion_ = IndexVersion::kV0; | |||
| }; | |||
|
|
|||
| class TermPostingsBuffer { | |||
There was a problem hiding this comment.
why we need this buffer? index input already has buffer inside.
zzzxl1993
force-pushed
the
202410121538
branch
3 times, most recently
from
7a42b2c
to
dd08cae
Compare
|
run buildall |
airborne12
requested changes
Oct 16, 2024
zzzxl1993
force-pushed
the
202410121538
branch
from
dd8bcb2
to
1761933
Compare
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.