[fix] Fix data loss due to internal retries #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem Summary:
After write optimization, the upstream data is read through the iterator. Since the iterator can only traverse in one direction, the current batch cannot be reread during the internal retry.
So the solution is to remove the internal retry, and the failure exception when executing the load will be thrown.
If the
spark.task.maxFailures
parameter is set (default value is 4), or other retry-related parameters, the Spark scheduler will retry the task.Other changes:
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...