Fix homepage user statistics result missing filter by user #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.0.1-prepare #7189 +/- ##
================================================
Coverage ? 32.10%
Complexity ? 1569
================================================
Files ? 433
Lines ? 14496
Branches ? 1440
================================================
Hits ? 4654
Misses ? 9383
Partials ? 459 Continue to review full report at Codecov.
|
zhongjiajie
commented
Dec 5, 2021
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/User.java
Outdated
Show resolved
Hide resolved
For now when we create new user, it would see homepage statisic info as admin user like, cause `projectCodeArray` would not filter when we render sql. So I add prefix condition to handle this situation. fix apache#7182
zhongjiajie
force-pushed
the
bug-homepage-user
branch
from
6df45dd
to
a3b591c
Compare
|
cc: @lenboo |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now when we create new user, it would see homepage
statisic info as admin user like, cause
projectCodeArraywould not filter when we render sql. So I add prefix condition
to handle this situation.
fix #7182