Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-16106] Add admin-user-filter in LDAP #16826

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

SbloodyS
Copy link
Member

@SbloodyS SbloodyS commented Nov 20, 2024

Purpose of the pull request

close #16106
close #16105

Brief change log

  • Add admin-user-filter in LDAP
  • Add api-test for LDAP login
  • LDAP docs improvement

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added this to the 3.3.0 milestone Nov 20, 2024
@SbloodyS SbloodyS self-assigned this Nov 20, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Nov 20, 2024
ruanwenjun
ruanwenjun previously approved these changes Nov 22, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruanwenjun
ruanwenjun previously approved these changes Nov 22, 2024
Copy link

sonarcloud bot commented Nov 22, 2024

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 627c76b into apache:dev Nov 22, 2024
68 of 70 checks passed
@SbloodyS SbloodyS deleted the improvement_16106 branch November 22, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend CI&CD document e2e e2e test improvement make more easy to user or prompt friendly test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][dolphinscheduler-api] Make ADMIN user a "memberOf" when using LDAP server
3 participants