Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][CI] fix the ci error of E2E-K8S-Execute #16031

Merged
merged 3 commits into from
May 21, 2024

Conversation

rickchengx
Copy link
Contributor

Purpose of the pull request

fix CI error
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@rickchengx rickchengx self-assigned this May 20, 2024
@github-actions github-actions bot removed the CI&CD label May 20, 2024
@rickchengx
Copy link
Contributor Author

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.62%. Comparing base (e4df01a) to head (61a543a).

Current head 61a543a differs from pull request most recent head 2a9c400

Please upload reports for the commit 2a9c400 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #16031   +/-   ##
=========================================
  Coverage     40.62%   40.62%           
  Complexity     5222     5222           
=========================================
  Files          1380     1380           
  Lines         46066    46066           
  Branches       4916     4916           
=========================================
  Hits          18714    18714           
  Misses        25428    25428           
  Partials       1924     1924           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the CI&CD label May 20, 2024
@rickchengx rickchengx changed the title [Fix][CI] fix the ci error of Values.datasource.profile [Fix][CI] fix the ci error of E2E-K8S-Execute May 20, 2024
@rickchengx rickchengx added 3.2.2 bug Something isn't working labels May 20, 2024
@EricGao888
Copy link
Member

Looks like #15922 attempted to make datasource configurable but forgot to add default values of profile in values.yaml, which causes CI to fail. What about add default profile values in values.yaml?

EricGao888
EricGao888 previously approved these changes May 20, 2024
@rickchengx
Copy link
Contributor Author

Looks like #15922 attempted to make datasource configurable but forgot to add default values of profile in values.yaml, which causes CI to fail. What about add default profile values in values.yaml?

Sure, I've added datasource.profile in values.yaml

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Radeity
Radeity previously approved these changes May 20, 2024
ruanwenjun
ruanwenjun previously approved these changes May 20, 2024
@rickchengx
Copy link
Contributor Author

Update deploy/kubernetes/dolphinscheduler/README.md

@Radeity
Copy link
Member

Radeity commented May 20, 2024

Hi @ruanwenjun , would you like to help check the failed UT?

@ruanwenjun
Copy link
Member

ruanwenjun commented May 20, 2024

Hi @ruanwenjun , would you like to help check the failed UT?

This might cause by the

block-until-connected: 600ms

is too small, I submit #16041 to fix this.

Copy link

sonarcloud bot commented May 21, 2024

@rickchengx rickchengx merged commit dbd790d into apache:dev May 21, 2024
63 checks passed
wangxj3 added a commit that referenced this pull request May 25, 2024
…ASF release (#16042)

* add version of 3.2.2

* Fix rpc channel leak due to concurrent operation (#16021)

* Fix rpc channel leak due to concurrent operation

* Throw channel create failed exception

---------

Co-authored-by: Rick Cheng <[email protected]>

* Fix WorkerTaskExecutorThreadPool#isOverload is incorrect (#16027)

* cp: Reduce the size of tarball to continue ASF release (#15004) (#15540)

* Reduce the size of tarball to continue ASF release

for more detail you can see https://lists.apache.org/thread/rmp7fghlj0n7h9y2v3p8gkw9f9qbo6qt
# Conflicts:
#	tools/dependencies/known-dependencies.txt

* Increase block-until-connected in ZookeeperRegistryTestCase (#16041)

* [Fix][CI] fix the ci error of Values.datasource.profile (#16031)

Co-authored-by: Eric Gao <[email protected]>

* Correction of Typos in the Chinese Document Appendix for Task Parameters (#16033)

Co-authored-by: Rick Cheng <[email protected]>

* [DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type (#15967)

* [Improvement][parameter] New data types and type filtering

* [Improvement][parameter] Improvement startup parameters/global parameters data type

* fix api interfaces compatible

* add project parameter data type default value

* [Improvement][parameter] New data types and type filtering

* [Improvement][parameter] Improvement startup parameters/global parameters data type

* fix api interfaces compatible

* add project parameter data type default value

* improvement project code

* remove useless imports

* remove method onClearSearchTaskType

* add parameter doc

* optimisation logic

* code conflict resolution

* code conflict resolution

* [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list (#15978)

* update

* test

* add monitor enhance ui

* update

* update

* update doc

* fix spotless

* update

* update

* Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml

Co-authored-by: Wenjun Ruan <[email protected]>

* update

* fix spotless

* update

---------

Co-authored-by: Wenjun Ruan <[email protected]>

* [Improvement][Monitor] Add UT for montor (#15998)

* formatting Code

* add pom

* Fix NettyRemotingClient might throw IllegalMonitorStateException (#16038)

* Removed unused StateEventHandleFailure (#16052)

* Remove OmitStackTraceInFastThrow in start.sh (#16054)

* Update Chart.yaml Rollback APPversion

* modify log msg (#16062)

Co-authored-by: xiangzihao <[email protected]>

* [DS-16046][fix] Set PreparedStatement parameter type (#16050)

Fix the PreparedStatement parameter is TIME, set it to java.sql.Time

Co-authored-by: Aaron Wang <[email protected]>
Co-authored-by: Rick Cheng <[email protected]>

* Update pom.xml

* [DSIP-42] Add dolphinscheduler-aws-authentication module  (#16043)

---------

Co-authored-by: wangxj <wangxj31>
Co-authored-by: Wenjun Ruan <[email protected]>
Co-authored-by: Rick Cheng <[email protected]>
Co-authored-by: Eric Gao <[email protected]>
Co-authored-by: TianXinCoord <[email protected]>
Co-authored-by: 小可耐 <[email protected]>
Co-authored-by: sleo <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
Co-authored-by: yinxiaolog <[email protected]>
Co-authored-by: Aaron Wang <[email protected]>
@SbloodyS SbloodyS added this to the 3.2.2 milestone Jun 26, 2024
SbloodyS pushed a commit to SbloodyS/dolphinscheduler that referenced this pull request Jun 26, 2024
SbloodyS added a commit that referenced this pull request Jun 26, 2024
* [Fix-16174] Incorrect cluster installation guide. (#16208)

* [Fix][CI] fix the ci error of Values.datasource.profile (#16031)

* [Improvement][Helm] Make configmap of api/master/worker/alert configuration (#16058)

Update deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml

* Update deploy/kubernetes/dolphinscheduler/values.yaml

* [helm] remove appversion from labels (#16066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants