-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use random port in registry IT #16014
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #16014 +/- ##
=========================================
Coverage 40.58% 40.58%
- Complexity 5215 5216 +1
=========================================
Files 1380 1380
Lines 46056 46056
Branches 4916 4916
=========================================
+ Hits 18692 18693 +1
Misses 25437 25437
+ Partials 1927 1926 -1 ☔ View full report in Codecov by Sentry. |
Please add the purpose of the pull request. |
Done |
Just curious, if the failure is due to port conflict, before this PR, it seems that UT will fail every time? |
I see most fail case is the UT run on jdk8/jdk11 at the same time, then fail, retry one by one can success. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, LGTM.
0da8d38
to
af4bfa0
Compare
Please retry analysis of this Pull-Request directly on SonarCloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md