Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-15969] [Helm] No DB Nodes Exist #15970

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Gallardot Gallardot changed the title [Bug] [Helm] No DB Nodes Exist [Fix-#15969] [Helm] No DB Nodes Exist May 10, 2024
@Gallardot Gallardot changed the title [Fix-#15969] [Helm] No DB Nodes Exist [Fix-15969] [Helm] No DB Nodes Exist May 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.93%. Comparing base (ad1a6af) to head (21af990).

❗ Current head 21af990 differs from pull request most recent head 3964f1d. Consider uploading reports for the commit 3964f1d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15970   +/-   ##
=========================================
  Coverage     39.93%   39.93%           
  Complexity     5081     5081           
=========================================
  Files          1369     1369           
  Lines         45635    45635           
  Branches       4869     4869           
=========================================
  Hits          18224    18224           
  Misses        25513    25513           
  Partials       1898     1898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added bug Something isn't working backend 3.2.2 labels May 10, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone May 10, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit ace20f9 into apache:dev May 10, 2024
62 checks passed
@Gallardot Gallardot deleted the fix-mysql-profile branch May 11, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Helm] No DB Nodes Exist
4 participants