-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jar path is not correct in java task #15906
Conversation
6af0638
to
6059341
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15906 +/- ##
============================================
+ Coverage 39.66% 39.74% +0.07%
- Complexity 5016 5037 +21
============================================
Files 1353 1353
Lines 45637 45619 -18
Branches 4892 4891 -1
============================================
+ Hits 18100 18129 +29
+ Misses 25622 25575 -47
Partials 1915 1915 ☔ View full report in Codecov by Sentry. |
6059341
to
2bcb524
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
28b1dbb
to
ffff286
Compare
ffff286
to
86e5b9c
Compare
86e5b9c
to
6075f2c
Compare
41f5d6c
to
4926250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some humble suggestion, next time, can you add additional explanations for the modifications made after PR is approved when performing a force-push? |
Thanks for your suggestion, I will add message next time, I'm just worried that these won't be cleaned up in the merger. |
4926250
to
9d95b18
Compare
Yeah, I can get your point, keep one commit is cleaner. With additional message, review the PR again will be faster :D |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
close #15902
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md