Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Completed tasks cannot be re-executed in a workflow instance #15884

Merged
merged 10 commits into from
May 9, 2024

Conversation

privking
Copy link
Contributor

Purpose of the pull request

When the task instance is re-executed in the workflow instance, the status of the instance (including history status) cannot be seen , and the details cannot be seen in the task instance list. But you can see from the log that the task has been executed.

I think the cause of this problem is that WorkflowExecuteRunnable.taskCodeInstanceMap did not remove the corresponding instance, and then in the submitPostNode method, there was an error in determining whether the task instance already existed.

By the way, I modified the WorkflowExecuteRunnable.completeTaskSet deletion logic in this method

bug

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun
Copy link
Member

Please create a issue to subscribe this problem.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.89%. Comparing base (8426d23) to head (6d295f1).

❗ Current head 6d295f1 differs from pull request most recent head 4c1c986. Consider uploading reports for the commit 4c1c986 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15884      +/-   ##
============================================
- Coverage     39.89%   39.89%   -0.01%     
  Complexity     5040     5040              
============================================
  Files          1355     1355              
  Lines         45564    45562       -2     
  Branches       4885     4885              
============================================
- Hits          18176    18175       -1     
  Misses        25484    25484              
+ Partials       1904     1903       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx added bug Something isn't working 3.2.2 labels May 6, 2024
Copy link

sonarcloud bot commented May 9, 2024

@rickchengx rickchengx merged commit bbca37d into apache:dev May 9, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants