-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Completed tasks cannot be re-executed in a workflow instance #15884
Conversation
This reverts commit 1546e9d.
Please create a issue to subscribe this problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15884 +/- ##
============================================
- Coverage 39.89% 39.89% -0.01%
Complexity 5040 5040
============================================
Files 1355 1355
Lines 45564 45562 -2
Branches 4885 4885
============================================
- Hits 18176 18175 -1
Misses 25484 25484
+ Partials 1904 1903 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Purpose of the pull request
When the task instance is re-executed in the workflow instance, the status of the instance (including history status) cannot be seen , and the details cannot be seen in the task instance list. But you can see from the log that the task has been executed.
I think the cause of this problem is that
WorkflowExecuteRunnable.taskCodeInstanceMap
did not remove the corresponding instance, and then in thesubmitPostNode
method, there was an error in determining whether the task instance already existed.By the way, I modified the
WorkflowExecuteRunnable.completeTaskSet
deletion logic in this methodBrief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md