Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ErrorCommand loss some fields in Command #15847

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixErrorCommandMissWorkflowDefinitionVersion branch from fe4dd1c to b9d084b Compare April 15, 2024 07:46
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixErrorCommandMissWorkflowDefinitionVersion branch from b9d084b to c0288d3 Compare April 15, 2024 07:46
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.52%. Comparing base (5ad7b15) to head (15af5ce).

❗ Current head 15af5ce differs from pull request most recent head c0288d3. Consider uploading reports for the commit c0288d3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15847      +/-   ##
============================================
+ Coverage     39.47%   39.52%   +0.04%     
- Complexity     4995     4996       +1     
============================================
  Files          1347     1347              
  Lines         45642    45646       +4     
  Branches       4892     4892              
============================================
+ Hits          18019    18042      +23     
+ Misses        25699    25680      -19     
  Partials       1924     1924              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qingwli qingwli added this to the 3.2.2 milestone Apr 15, 2024
Copy link

sonarcloud bot commented Apr 15, 2024

Copy link
Member

@qingwli qingwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingwli qingwli added bug Something isn't working ready-to-merge labels Apr 15, 2024
@qingwli qingwli merged commit 6844c65 into apache:dev Apr 15, 2024
60 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixErrorCommandMissWorkflowDefinitionVersion branch April 15, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants