-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-15787] Reuse code and solve the problem of complex SQL parsing exceptions in… #15833
Conversation
… druid, corresponding to issue apache#15787
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xinxingi Please fix UT.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15833 +/- ##
============================================
+ Coverage 39.47% 39.54% +0.06%
- Complexity 4993 5020 +27
============================================
Files 1347 1347
Lines 45641 45642 +1
Branches 4892 4891 -1
============================================
+ Hits 18018 18050 +32
+ Misses 25699 25668 -31
Partials 1924 1924 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
@qingwli @SbloodyS The UT that reports the error is meaningful. The com.alibaba.druid.sql.parser.SQLParserUtils.splitAndRemoveComment tool class does not do special processing for Oracle, which requires overall execution of PL/SQL. As a result, a complete statement will be incorrectly split. After correcting the logic of the code, I conducted unit tests on a series of PL/SQL statements and multiple compound SQL statements, and the tests all passed. But I didn't submit the code because there were too many test samples. If necessary, I will provide a comprehensive test sample in the comment area or make a git submission. I will continue to follow up on the maintenance of this data source from now on |
That's ok @xinxingi , This pr is merged, Thanks for your contributing |
… druid, corresponding to issue fix #15787
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md