-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cannot construct instance of StreamingTaskTriggerResponse #15816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15816 +/- ##
============================================
- Coverage 39.26% 39.17% -0.10%
+ Complexity 4914 4889 -25
============================================
Files 1323 1323
Lines 45187 45187
Branches 4811 4811
============================================
- Hits 17744 17703 -41
- Misses 25561 25603 +42
+ Partials 1882 1881 -1 ☔ View full report in Codecov by Sentry. |
Could you please add UT for this case? |
…er.transportor.StreamingTaskTriggerResponse (no Creators, like default constructor, exist): cannot deserialize from Object value (no delegate- or property-based Creator) apache#15814
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…er.transportor.StreamingTaskTriggerResponse (no Creators, like default constructor, exist): cannot deserialize from Object value (no delegate- or property-based Creator) fix #15814
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md