Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot construct instance of StreamingTaskTriggerResponse #15816

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

atjiucheng
Copy link
Contributor

@atjiucheng atjiucheng commented Apr 9, 2024

…er.transportor.StreamingTaskTriggerResponse (no Creators, like default constructor, exist): cannot deserialize from Object value (no delegate- or property-based Creator) fix #15814

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun changed the title Cannot construct instance of org.apache.dolphinscheduler.extract.master.transportor.StreamingTaskTriggerResponse (no Creators, like default constructor, exist): cannot deserialize from Object value (no delegate- or property-based Creator) #15814 Fix cannot construct instance of StreamingTaskTriggerResponse Apr 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.17%. Comparing base (f93b27e) to head (526c4f0).

❗ Current head 526c4f0 differs from pull request most recent head 958e9f5. Consider uploading reports for the commit 958e9f5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15816      +/-   ##
============================================
- Coverage     39.26%   39.17%   -0.10%     
+ Complexity     4914     4889      -25     
============================================
  Files          1323     1323              
  Lines         45187    45187              
  Branches       4811     4811              
============================================
- Hits          17744    17703      -41     
- Misses        25561    25603      +42     
+ Partials       1882     1881       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun
Copy link
Member

Could you please add UT for this case?

@SbloodyS SbloodyS added 3.2.2 first time contributor First-time contributor labels Apr 9, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Apr 9, 2024
…er.transportor.StreamingTaskTriggerResponse (no Creators, like default constructor, exist): cannot deserialize from Object value (no delegate- or property-based Creator) apache#15814
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added ready-to-merge bug Something isn't working labels Apr 11, 2024
@ruanwenjun ruanwenjun merged commit 2b5f843 into apache:dev Apr 11, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend bug Something isn't working first time contributor First-time contributor ready-to-merge
Projects
None yet
5 participants