[DSIP] Support ssl at RPC

[fuchanghai]

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

[ruanwenjun]

Could you please add doc and ut for this?

[ruanwenjun]

Pleas move this kind of config into application.yaml, we shouldn't add new config into common.properties.

rpc:
   ssl:
       enable: true
       cert-file: 
       key-file: 

[fuchanghai]

i add config into common.properties,Because if the master service uses SSL authentication, the worker must also be configured。 so i think only config into common better than config both into master and worker

[rickchengx]

Overall LGTM, Even if these configs are in common.properties, the common.properties of the master and worker may have different configs. I think it is necessary to deal with the inconsistency in encryption.

So I agree with @ruanwenjun that we could move these configs to application.yaml

[ruanwenjun]

Since this will import new feature, please create a DSIP issue, you can follow #14102

[fuchanghai]

Could you please add doc and ut for this?

of course ,I will add it recently

[fuchanghai]

I want to wait until my code structure is ok and everyone’s review has passed before I add UT. @ruanwenjun @rickchengx

[Gallardot]

The documentation on how to use SSL also needs to be updated. At the same time, the Helm charts need to be updated to support this capability. @fuchanghai

[fuchanghai]

The documentation on how to use SSL also needs to be updated. At the same time, the Helm charts need to be updated to support this capability. @fuchanghai

get

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 39.86%. Comparing base (60b019b) to head (626be70).

❗ Current head 626be70 differs from pull request most recent head 3c11124. Consider uploading reports for the commit 3c11124 to get more accurate results

Files	Patch %	Lines
...duler/extract/base/client/NettyRemotingClient.java	27.27%	6 Missing and 2 partials ⚠️
...duler/extract/base/server/NettyRemotingServer.java	27.27%	6 Missing and 2 partials ⚠️
...e/dolphinscheduler/server/master/MasterServer.java	0.00%	1 Missing ⚠️
...e/dolphinscheduler/server/worker/WorkerServer.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #15802      +/-   ##
============================================
- Coverage     39.93%   39.86%   -0.08%     
+ Complexity     5081     5061      -20     
============================================
  Files          1369     1369              
  Lines         45635    45662      +27     
  Branches       4869     4872       +3     
============================================
- Hits          18224    18201      -23     
- Misses        25513    25558      +45     
- Partials       1898     1903       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[davidzollo]

Thanks for the contribution from changhai , there are some conflicts, and now @wangxj3 will submit a new PR to solve this issue refer to this PR.

Thanks again