Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][RemoteLogging] Move init into loghandler #15780

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Mar 29, 2024

Purpose of the pull request

see #15769
move init inside contructor.

Brief change log

see #15769

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun changed the title [RemoteLogging] Move init into loghandler [Improvement][RemoteLogging] Move init into loghandler Mar 30, 2024
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. labels Mar 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 39.16%. Comparing base (dc4dad1) to head (070c742).

❗ Current head 070c742 differs from pull request most recent head ec764c6. Consider uploading reports for the commit ec764c6 to get more accurate results

Files Patch % Lines
...cheduler/common/log/remote/S3RemoteLogHandler.java 0.00% 7 Missing ⚠️
...heduler/common/log/remote/OssRemoteLogHandler.java 0.00% 6 Missing ⚠️
...heduler/common/log/remote/GcsRemoteLogHandler.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15780      +/-   ##
============================================
- Coverage     39.16%   39.16%   -0.01%     
+ Complexity     4867     4866       -1     
============================================
  Files          1316     1316              
  Lines         44978    44978              
  Branches       4803     4803              
============================================
- Hits          17617    17615       -2     
- Misses        25477    25478       +1     
- Partials       1884     1885       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidzollo davidzollo merged commit d39bdcb into apache:dev Mar 31, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants