Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug][ui] add missing datasource and update datasource id #15776

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

whhe
Copy link
Member

@whhe whhe commented Mar 28, 2024

Purpose of the pull request

Add 'OCEANBASE' and update other items to keep them same with enum DbType.
Close #15778.

Brief change log

Fix datasource list in ui.

Verify this pull request

Test locally.

@github-actions github-actions bot added the UI ui and front end related label Mar 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.10%. Comparing base (929f4cf) to head (8b2912a).

❗ Current head 8b2912a differs from pull request most recent head 5030dff. Consider uploading reports for the commit 5030dff to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15776      +/-   ##
============================================
- Coverage     39.10%   39.10%   -0.01%     
  Complexity     4853     4853              
============================================
  Files          1316     1316              
  Lines         44945    44945              
  Branches       4800     4800              
============================================
- Hits          17576    17575       -1     
- Misses        25478    25479       +1     
  Partials       1891     1891              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whhe whhe changed the title hotfix(ui): fix databaseTypes following the DbType in spi module [bug][ui] add missing datasource and update datasource id Mar 28, 2024
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to issue. @whhe

@rickchengx rickchengx added bug Something isn't working 3.2.2 labels Mar 29, 2024
@whhe
Copy link
Member Author

whhe commented Mar 29, 2024

Please link to issue. @whhe

Hi @SbloodyS, the issue has been created and linked to this pr.

@SbloodyS SbloodyS added this to the 3.2.2 milestone Mar 29, 2024
@SbloodyS SbloodyS merged commit 723126b into apache:dev Mar 29, 2024
60 checks passed
@ruanwenjun ruanwenjun mentioned this pull request May 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 bug Something isn't working ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [ui] 'OCEANBASE' type is missing in datasource list
5 participants