Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix ui build error #15732

Merged
merged 1 commit into from
Mar 18, 2024
Merged

[CI] Fix ui build error #15732

merged 1 commit into from
Mar 18, 2024

Conversation

SbloodyS
Copy link
Member

@SbloodyS SbloodyS commented Mar 18, 2024 •
edited
Loading

Purpose of the pull request

Fix ui build error in #15681 (comment)

@github-actions github-actions bot added the UI ui and front end related label Mar 18, 2024
@SbloodyS SbloodyS marked this pull request as ready for review March 18, 2024 09:02
@SbloodyS SbloodyS self-assigned this Mar 18, 2024
@SbloodyS SbloodyS added 3.2.2 bug Something isn't working chore labels Mar 18, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Mar 18, 2024
@SbloodyS SbloodyS mentioned this pull request Mar 18, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

zhongjiajie
zhongjiajie reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we have so many style only change here? I think we should avoid it, is there any dependence upgrade in recent day?

@zhongjiajie
Copy link
Member

Ok, I got it, we merge some incorrect format code to our codebase before

@zhongjiajie
Copy link
Member

seems bot mergeable not working right now 😕

@SbloodyS SbloodyS merged commit faa794c into apache:dev Mar 18, 2024
57 of 58 checks passed
@SbloodyS SbloodyS deleted the fix_ui_build_error branch March 18, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@SbloodyS SbloodyS

Labels
3.2.2 bug Something isn't working chore ready-to-merge UI ui and front end related
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@SbloodyS @zhongjiajie