[Bug] Disable delete a specific workflow version when exist workflow instance under this version which is not finish #15730
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @param taskDefinitionJson taskDefinitionJson | ||
| * @param otherParamsJson otherParamsJson handle other params | ||
| * @param otherParamsJson otherParamsJson handle other params |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
| * @param projectCode project code | ||
| * @param code the process definition code | ||
| * @param version the process definition version user want to delete | ||
| * @param code the process definition code |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
| * @param code the process definition code | ||
| * @param version the process definition version user want to delete | ||
| * @param code the process definition code | ||
| * @param version the process definition version user want to delete |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
ruanwenjun
force-pushed
the
dev_wenjun_cannotDeleteWorkflowVersionWhenExistRunningInstance
branch
from
9e9e421
to
d8bb8ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15730 +/- ##
============================================
- Coverage 39.11% 39.09% -0.03%
+ Complexity 4855 4852 -3
============================================
Files 1316 1316
Lines 44963 44967 +4
Branches 4810 4810
============================================
- Hits 17589 17579 -10
- Misses 25474 25489 +15
+ Partials 1900 1899 -1 ☔ View full report in Codecov by Sentry. |
|
I have a question not directly related to this PR. Since currently we encapsulate the whole query stuff in Mappers, do we still need DAOs? It seems our DAOs have already lost the function of decoupling. |
it's better to return DO in the Mapper, and return DTO in DAO. So the DAO might contain some merge or transform function. |
ruanwenjun
force-pushed
the
dev_wenjun_cannotDeleteWorkflowVersionWhenExistRunningInstance
branch
from
3f3a407
to
818d91f
Compare
ruanwenjun
force-pushed
the
dev_wenjun_cannotDeleteWorkflowVersionWhenExistRunningInstance
branch
from
818d91f
to
1854968
Compare
…instance under this version which is not finish
ruanwenjun
force-pushed
the
dev_wenjun_cannotDeleteWorkflowVersionWhenExistRunningInstance
branch
from
ca29e1e
to
e3d8979
Compare
|
ruanwenjun
deleted the
dev_wenjun_cannotDeleteWorkflowVersionWhenExistRunningInstance
branch
Purpose of the pull request
When we delete a specific workflow definition version that contains running workflow instances, then the workflow instance might get an unexcepted status and we cannot open the workflow instance detail page since missing metadaba.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md