Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recover pause workflowInstance may generate failover taskInstance #15611

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Feb 22, 2024

Purpose of the pull request

close #15612

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5213290) 38.58% compared to head (c25faa3) 38.60%.

❗ Current head c25faa3 differs from pull request most recent head e0bcc71. Consider uploading reports for the commit e0bcc71 to get more accurate results

Files Patch % Lines
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15611      +/-   ##
============================================
+ Coverage     38.58%   38.60%   +0.01%     
- Complexity     4784     4785       +1     
============================================
  Files          1312     1312              
  Lines         44978    44978              
  Branches       4819     4819              
============================================
+ Hits          17355    17363       +8     
+ Misses        25733    25723      -10     
- Partials       1890     1892       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 22, 2024

@ruanwenjun ruanwenjun added bug Something isn't working ready-to-merge labels Feb 22, 2024
@ruanwenjun ruanwenjun self-assigned this Feb 22, 2024
@ruanwenjun ruanwenjun merged commit 2b4c1e0 into apache:dev Feb 22, 2024
56 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixRecoveryPauseTask branch February 22, 2024 07:57
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Feb 22, 2024
@ruanwenjun ruanwenjun added 3.2.1 and removed 3.2.2 labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Recovery paused workflowInstance may generate failover taskInstance
3 participants