Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data quality may fail in docker mode #15563

Merged
merged 14 commits into from
Feb 5, 2024
Merged

fix: data quality may fail in docker mode #15563

merged 14 commits into from
Feb 5, 2024

Conversation

zhongjiajie
Copy link
Member

append on #15551 comment #15551 (comment)

@zhongjiajie zhongjiajie self-assigned this Feb 5, 2024
@zhongjiajie zhongjiajie added this to the 3.2.1 milestone Feb 5, 2024
@zhongjiajie zhongjiajie added the improvement make more easy to user or prompt friendly label Feb 5, 2024
caishunfeng
caishunfeng approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024 •
edited
Loading

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (01eb8f8) 0.00% compared to head (610bcba) 38.38%.

❗ Current head 610bcba differs from pull request most recent head d55c210. Consider uploading reports for the commit d55c210 to get more accurate results

Files Patch % Lines
...duler/plugin/datasource/api/utils/CommonUtils.java 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             dev   #15563       +/-   ##
==========================================
+ Coverage       0   38.38%   +38.38%     
- Complexity     0     4747     +4747     
==========================================
  Files          0     1305     +1305     
  Lines          0    44839    +44839     
  Branches       0     4803     +4803     
==========================================
+ Hits           0    17213    +17213     
- Misses         0    25752    +25752     
- Partials       0     1874     +1874

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

44.2% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@zhongjiajie zhongjiajie modified the milestone: 3.2.1 Feb 5, 2024
@zhongjiajie zhongjiajie added ready-to-merge improvement make more easy to user or prompt friendly and removed improvement make more easy to user or prompt friendly labels Feb 5, 2024
@zhongjiajie zhongjiajie merged commit 91d56f4 into apache:dev Feb 5, 2024
55 of 56 checks passed
@zhongjiajie zhongjiajie deleted the dq-bug branch February 5, 2024 09:15
zhongjiajie added a commit that referenced this pull request Feb 6, 2024
@zhongjiajie
fix: data quality may fail in docker mode (#15563)
e2d08fc 
(cherry picked from commit 91d56f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@zhongjiajie zhongjiajie

Labels
backend document e2e e2e test improvement make more easy to user or prompt friendly ready-to-merge test
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@zhongjiajie @codecov-commenter @caishunfeng @rickchengx @EricGao888