Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Throw IllegalArgumentException if parse time placeholder error #15514

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jan 19, 2024

Purpose of the pull request

Avoid throw NPE or some other unreadable Exception.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly 3.2.1 labels Jan 20, 2024
@ruanwenjun ruanwenjun changed the title Throw IllegalArgumentException if parse time placeholder error [Improvement] Throw IllegalArgumentException if parse time placeholder error Jan 20, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionWhenTimeParseError branch from 6b05243 to 26544c7 Compare January 20, 2024 09:30
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (308e4fb) 38.01% compared to head (368a023) 38.02%.

❗ Current head 368a023 differs from pull request most recent head 26544c7. Consider uploading reports for the commit 26544c7 to get more accurate results

Files Patch % Lines
...r/plugin/task/api/parser/TimePlaceholderUtils.java 50.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15514   +/-   ##
=========================================
  Coverage     38.01%   38.02%           
- Complexity     4692     4693    +1     
=========================================
  Files          1304     1304           
  Lines         44814    44812    -2     
  Branches       4804     4804           
=========================================
+ Hits          17038    17040    +2     
+ Misses        25924    25921    -3     
+ Partials       1852     1851    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

17 New issues
0 Security Hotspots
64.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 5a7deb2 into apache:dev Jan 22, 2024
56 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_throwExceptionWhenTimeParseError branch January 22, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants