Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][E2E] add e2e javatask case #15469

Merged
merged 21 commits into from
Jan 12, 2024
Merged

Conversation

jackyyyyyssss
Copy link
Contributor

@jackyyyyyssss jackyyyyyssss commented Jan 11, 2024

Purpose of the pull request

add e2e java test #15478

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to split bugfix and feature into two PR. @jackyyyyyssss

@jackyyyyyssss
Copy link
Contributor Author

It's better to split bugfix and feature into two PR. @jackyyyyyssss

ok .I will submit another PR to fix the bug in the Javatask classpath

@jackyyyyyssss jackyyyyyssss changed the title [Improvement][E2E] fix bug javatask classpath and add e2e javatask case [Improvement][E2E] add e2e javatask case Jan 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd48c99) 38.13% compared to head (20dc7aa) 38.11%.

❗ Current head 20dc7aa differs from pull request most recent head f6f0f25. Consider uploading reports for the commit f6f0f25 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15469      +/-   ##
============================================
- Coverage     38.13%   38.11%   -0.03%     
+ Complexity     4698     4696       -2     
============================================
  Files          1299     1299              
  Lines         44775    44775              
  Branches       4797     4797              
============================================
- Hits          17075    17066       -9     
- Misses        25851    25861      +10     
+ Partials       1849     1848       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SbloodyS SbloodyS added the 3.3.0 label Jan 12, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jan 12, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jan 12, 2024
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit 3c7a77c into apache:dev Jan 12, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 backend CI&CD e2e e2e test improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants