Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement][api] Fix typo for controllers #15438

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

CommandCV
Copy link
Contributor

Purpose of the pull request

Fix typo for controllers.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added first time contributor First-time contributor 3.2.1 labels Jan 8, 2024
@SbloodyS SbloodyS added this to the 3.2.1 milestone Jan 8, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a7deb2) 38.02% compared to head (34e41af) 38.02%.

❗ Current head 34e41af differs from pull request most recent head 03df33b. Consider uploading reports for the commit 03df33b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15438   +/-   ##
=========================================
  Coverage     38.02%   38.02%           
  Complexity     4693     4693           
=========================================
  Files          1304     1304           
  Lines         44812    44812           
  Branches       4804     4804           
=========================================
  Hits          17040    17040           
  Misses        25921    25921           
  Partials       1851     1851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuchanghai fuchanghai removed the first time contributor First-time contributor label Jan 19, 2024
Copy link

sonarcloud bot commented Jan 23, 2024

@rickchengx rickchengx merged commit 95ae003 into apache:dev Jan 24, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants