-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][E2E]e2e improve add workflow httpTask e2e case #15420
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15420 +/- ##
============================================
- Coverage 38.12% 38.11% -0.01%
+ Complexity 4697 4696 -1
============================================
Files 1299 1299
Lines 44774 44774
Branches 4799 4799
============================================
- Hits 17068 17067 -1
Misses 25855 25855
- Partials 1851 1852 +1 ☔ View full report in Codecov by Sentry. |
@SbloodyS The code modified this time will not affect the backend in the e2e package. It seems that the error is due to a port conflict on the GitHub machine. I tried again in the local repository and it was successful. The use case for this time has been successful. Please help me try again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Just some NIT.
...e2e/dolphinscheduler-e2e-case/src/test/resources/docker/workflow-http/mockserver-config.json
Outdated
Show resolved
Hide resolved
f4af698
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Purpose of the pull request
E2e improve add workflow httpTask e2e case
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md