Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][E2E]e2e improve add workflow httpTask e2e case #15420

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

jackyyyyyssss
Copy link
Contributor

Purpose of the pull request

E2e improve add workflow httpTask e2e case

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added UI ui and front end related CI&CD e2e e2e test labels Jan 3, 2024
@jackyyyyyssss jackyyyyyssss changed the title E2e improve add workflow httpTask e2e case [Improvement][E2E]e2e improve add workflow httpTask e2e case Jan 3, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jan 4, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f21a7a) 38.12% compared to head (5d4f50b) 38.11%.

❗ Current head 5d4f50b differs from pull request most recent head 9b1c9c2. Consider uploading reports for the commit 9b1c9c2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15420      +/-   ##
============================================
- Coverage     38.12%   38.11%   -0.01%     
+ Complexity     4697     4696       -1     
============================================
  Files          1299     1299              
  Lines         44774    44774              
  Branches       4799     4799              
============================================
- Hits          17068    17067       -1     
  Misses        25855    25855              
- Partials       1851     1852       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackyyyyyssss
Copy link
Contributor Author

@SbloodyS The code modified this time will not affect the backend in the e2e package. It seems that the error is due to a port conflict on the GitHub machine. I tried again in the local repository and it was successful. The use case for this time has been successful. Please help me try again
image
image
image

songjianet
songjianet previously approved these changes Jan 4, 2024
SbloodyS
SbloodyS previously approved these changes Jan 4, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Just some NIT.

@jackyyyyyssss jackyyyyyssss dismissed stale reviews from SbloodyS and songjianet via f4af698 January 4, 2024 06:24
@github-actions github-actions bot removed the backend label Jan 4, 2024
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@SbloodyS SbloodyS merged commit 4c31e19 into apache:dev Jan 5, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 CI&CD e2e e2e test improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants