Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parse task output params under multiple log #15244

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Nov 29, 2023

Purpose of the pull request

  • Support parse task output params which composite with multiple lines
  • Unify k8s task varpool.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun requested review from Radeity and removed request for caishunfeng, SbloodyS and zhuangchong November 29, 2023 14:30
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly and removed backend labels Nov 29, 2023
@mergeable mergeable bot added backend and removed improvement make more easy to user or prompt friendly labels Nov 29, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportParseVarpoolUnderMultipleLine branch 6 times, most recently from d3067d8 to dcaa151 Compare November 30, 2023 03:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (b4cf1cc) 38.00% compared to head (d243348) 38.05%.

❗ Current head d243348 differs from pull request most recent head 115b280. Consider uploading reports for the commit 115b280 to get more accurate results

Files Patch % Lines
...duler/plugin/task/api/AbstractCommandExecutor.java 0.00% 19 Missing ⚠️
...gin/task/api/parser/TaskOutputParameterParser.java 61.53% 8 Missing and 7 partials ⚠️
...scheduler/plugin/task/api/k8s/AbstractK8sTask.java 0.00% 3 Missing ⚠️
...uler/plugin/task/api/k8s/impl/K8sTaskExecutor.java 40.00% 3 Missing ⚠️
...plugin/task/api/parameters/AbstractParameters.java 25.00% 3 Missing ⚠️
...olphinscheduler/plugin/task/linkis/LinkisTask.java 0.00% 3 Missing ⚠️
...hinscheduler/plugin/task/api/AbstractYarnTask.java 0.00% 2 Missing ⚠️
...phinscheduler/plugin/task/chunjun/ChunJunTask.java 0.00% 2 Missing ⚠️
...olphinscheduler/plugin/task/python/PythonTask.java 50.00% 2 Missing ⚠️
...dolphinscheduler/plugin/task/api/AbstractTask.java 0.00% 1 Missing ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15244      +/-   ##
============================================
+ Coverage     38.00%   38.05%   +0.05%     
- Complexity     4639     4661      +22     
============================================
  Files          1279     1279              
  Lines         44505    44553      +48     
  Branches       4800     4802       +2     
============================================
+ Hits          16915    16956      +41     
  Misses        25730    25730              
- Partials       1860     1867       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportParseVarpoolUnderMultipleLine branch 7 times, most recently from 7bb2b60 to 933e7ae Compare November 30, 2023 04:53
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportParseVarpoolUnderMultipleLine branch from 933e7ae to 115b280 Compare November 30, 2023 09:39
Copy link

sonarcloud bot commented Nov 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

47.2% 47.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Nov 30, 2023
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Radeity Radeity added this to the 3.2.1 milestone Nov 30, 2023
@ruanwenjun ruanwenjun merged commit 71ee1f0 into apache:dev Dec 1, 2023
52 of 53 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_supportParseVarpoolUnderMultipleLine branch December 1, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend document improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants