Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Workflow instance can't stop due to doesn't refresh status in master #15191

Merged
merged 1 commit into from
Nov 20, 2023
Merged

[Bug] Workflow instance can't stop due to doesn't refresh status in master #15191

merged 1 commit into from
Nov 20, 2023

Conversation

Dyqer
Copy link
Contributor

@Dyqer Dyqer commented Nov 20, 2023

Purpose of the pull request

we can't stop the process instance, because master not refresh the process status from DB

ruanwenjun
ruanwenjun approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, this should be refactor, all workflow status change should happen in master.

@ruanwenjun ruanwenjun changed the title [Bug] fix can't stop bug [Bug] Workflow instance can't stop due to doesn't refresh status in master Nov 20, 2023
@Dyqer
Copy link
Contributor Author

Dyqer commented Nov 20, 2023

Basically LGTM, this should be refactor, all workflow status change should happen in master.

@ruanwenjun Sounds great, but some times, there are many process instance's host is null, which master should duty on this part？

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SbloodyS SbloodyS added first time contributor First-time contributor 3.2.1 labels Nov 20, 2023
@SbloodyS SbloodyS added this to the 3.2.1 milestone Nov 20, 2023
@SbloodyS SbloodyS added bug Something isn't working ready-to-merge labels Nov 20, 2023
@SbloodyS SbloodyS merged commit cca1c4a into apache:dev Nov 20, 2023
53 checks passed
@ruanwenjun
Copy link
Member

Basically LGTM, this should be refactor, all workflow status change should happen in master.

@ruanwenjun Sounds great, but some times, there are many process instance's host is null, which master should duty on this part？

The workflow instance's host should not be null, the host will be inject when the workflow instance initialized.

@2421994771
Copy link

Purpose of the pull request

we can't stop the process instance, because master not refresh the process status from DB
I also encountered the same problem, which is less likely to happen. However, when the master received the state change event, he would refresh the context, but the state was still inconsistent with the database after the refresh. I want to know why the inconsistency occurred. The above submission solves the problem, but does not explain why the state is inconsistent, if you know, can you tell me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@Dyqer Dyqer

Labels
3.2.1 backend bug Something isn't working first time contributor First-time contributor ready-to-merge
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Dyqer @ruanwenjun @2421994771 @SbloodyS